Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix py-thrift-namespace-clash-check type issue when logging with --no-strict mode #7864

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Fix py-thrift-namespace-clash-check type issue when logging with --no-strict mode #7864

merged 4 commits into from
Jun 6, 2019

Commits on Jun 6, 2019

  1. Fix py-thrift-namespace-clash-check logging issue when using --no-strict

    @Eric-Arellano
    Eric-Arellano committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    d159d68 View commit details
    Browse the repository at this point in the history

  2. Add assertion to avoid this from happening again.

    @Eric-Arellano
    Eric-Arellano committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    380c356 View commit details
    Browse the repository at this point in the history

  3. Add builtins imports

    @Eric-Arellano
    Eric-Arellano committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    07b8185 View commit details
    Browse the repository at this point in the history

  4. Allow bytes so that Python 2 works properly

    @Eric-Arellano
    Eric-Arellano committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    dd7022f View commit details
    Browse the repository at this point in the history