Deflake test #8153
Merged
Deflake test #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way backing in is implemented, we halve the backoff period per successful request, rather than based on time. The `expect_only_good` method makes an unpredictable number of requests, filling a time window rather. So this test would pass when the number of requests happened to align with the time window (which appears to be common on travis's CPUs), and fail if they got out of sync. We currently have no tests for the actual backing in behaviour, but I think that's mostly ok; we have tests that shows that we start using servers again, and we can add more if we need to.
pierrechevalier83
approved these changes
Aug 9, 2019
blorente
approved these changes
Aug 9, 2019
stuhood
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way backing in is implemented, we halve the backoff period per
successful request, rather than based on time. The
expect_only_goodmethod makes an unpredictable number of requests, filling a time window
rather.
So this test would pass when the number of requests happened to align
with the time window (which appears to be common on travis's CPUs), and
fail if they got out of sync.
We currently have no tests for the actual backing in behaviour, but I
think that's mostly ok; we have tests that shows that we start using
servers again, and we can add more if we need to.
Fixes #7836