Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip two flaky tests and tweak more test timeouts #8687

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

Eric-Arellano
Copy link
Contributor

Skip some exception sink integration tests on macOS

These shards have chronically flaked by hanging since at least July #8127. They are our most egregious Python flake.

We will still test these four tests on Linux and only skip them on macOS, as this is a macOS specific
issue.

Skip remote::tests::dropped_request_cancels

This seems to flake roughly 40% of the time #8405. It is our most egregious Rust flake.

Tweak some other tests

We mark some other tests as flaky and bump their timeouts as relevant to hopefully stabilize CI further.

@Eric-Arellano
Copy link
Contributor Author

Incredible: I think this is the first time I've had a CI run be green on the first try in over 2 months 🎉

(Although, we shouldn't be too excited. The way we got this was through skips and retries, rather than fixing the underlying issues.)

@Eric-Arellano Eric-Arellano merged commit d98e53a into pantsbuild:master Nov 22, 2019
@Eric-Arellano Eric-Arellano deleted the skip-exception-sink branch November 22, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants