Disable watchman by default. #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2020 22:05
[ci skip-jvm-tests]
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
Eric-Arellano
approved these changes
May 7, 2020
| @@ -1063,6 +1064,8 @@ def validate_instance(cls, opts): | |||
| Raises pants.option.errors.OptionsError on validation failure. | |||
| """ | |||
| if opts.get("loop") and not opts.enable_pantsd: | |||
| # TODO: This remains the case today because there are two spots that | |||
| # call `run_goal_rules`: fixing in a followup. | |||
[ci skip-jvm-tests]
jsirois
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using the notify crate for file invalidation is now feature complete, and so we are using two file watching implementations simultaneously under
pantsd.Solution
Disable watchman by default, and deprecate it. Additionally, remove the implementation of the
experimentalflag from notify. Fixes #8710, fixes #8198, fixes #7375, fixes #5487, fixes #4999, fixes #3479.