Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PANTS_SHA install caching. #174

Merged
merged 2 commits into from
May 9, 2023
Merged

Fix PANTS_SHA install caching. #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3cac58
Fix PANTS_SHA install caching.
jsirois May 9, 2023
bb16cba
Fix formatting.
jsirois May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@
/.pants.d/
/.pids/

# Python bytecode
__pycache__/
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes

## 0.6.1

This release fixes `PANTS_SHA` support to properly cache the resulting Pants install.

## 0.6.0

Support the `PANTS_TOML` environment variable for specifying a location other than the project's
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ members = [
[package]
name = "scie-pants"
description = "Protects your Pants from the elements."
version = "0.6.0"
version = "0.6.1"
edition = "2021"
authors = [
"John Sirois <john.sirois@gmail.com>",
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ fn get_pants_process() -> Result<Process> {
env.push(("_PANTS_OVERRIDE_VERSION".into(), version.clone().into()));
}
env.push(("PANTS_VERSION".into(), version.into()));
} else {
} else if env_pants_sha.is_none() {
// Ensure the install binding always re-runs when no Pants version is found so that the
// the user can be prompted with configuration options.
env.push((
Expand Down