Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parquet column parsing #127

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

PhilippLgh
Copy link
Contributor

@PhilippLgh PhilippLgh commented Nov 16, 2023

Motivation

cryo seems to treat --txs args in path:column notation as tx hex values and fails to read them.

cryo performs a file.exists() check on a path that might be formatted as path:column.

it should handle these inputs as per:
- can use a parquet file --txs ./path/to/file.parquet[:COLUMN_NAME]

Solution

use the parse_file_column_reference() helper to retrieve only the path without the column part.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@sslivkoff
Copy link
Member

hey sorry for the delay on this. the pr lgtm. formatting can be fixed by running cargo +nightly fmt --all

@sslivkoff sslivkoff merged commit 17d25d7 into paradigmxyz:main Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants