Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path instead of String for output dir. #37

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Use Path instead of String for output dir. #37

merged 2 commits into from
Aug 29, 2023

Conversation

kskalski
Copy link
Contributor

Motivation

Use of strings for operating on paths is error prone and more verbose

Solution

Use std::path::Path and std::path::PathBuf for output paths processing

PR Checklist

  • [refactor] Added Tests
  • [no new code] Added Documentation
  • [none] Breaking changes

@sslivkoff sslivkoff merged commit 856c4ae into paradigmxyz:main Aug 29, 2023
3 checks passed
@kskalski kskalski deleted the enhance/path branch August 30, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kskalski @sslivkoff