Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive rpc tests: websocket tests fail and time out in CI #2704

Closed
1 task done
Rjected opened this issue May 17, 2023 · 1 comment · Fixed by #2831
Closed
1 task done

Hive rpc tests: websocket tests fail and time out in CI #2704

Rjected opened this issue May 17, 2023 · 1 comment · Fixed by #2831
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test

Comments

@Rjected
Copy link
Member

Rjected commented May 17, 2023

Describe the bug

Currently most of the websocket tests in the ethereum/rpc test suite fail:

INFO[05-16|00:27:02] API: test started                        suite=0 test=32 name="ws/TransactionInBlock (reth)"
INFO[05-16|00:27:02] API: test ended                          suite=0 test=18 pass=false
INFO[05-16|00:27:02] API: test started                        suite=0 test=33 name="ws/TransactionReceipt (reth)"
INFO[05-16|00:27:02] API: test ended                          suite=0 test=21 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=23 pass=false
INFO[05-16|00:27:02] API: test started                        suite=0 test=34 name="ws/NewHeadSubscription (reth)"
INFO[05-16|00:27:02] API: test ended                          suite=0 test=24 pass=false
INFO[05-16|00:27:02] API: test started                        suite=0 test=35 name="ws/LogSubscription (reth)"
INFO[05-16|00:27:02] API: test started                        suite=0 test=36 name="ws/TransactionInBlockSubscription (reth)"
INFO[05-16|00:27:02] API: test ended                          suite=0 test=9 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=8 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=15 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=10 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=19 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=17 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=29 pass=false
INFO[05-16|00:27:02] API: test ended                          suite=0 test=4 pass=false
INFO[05-16|00:27:02] API: test started                        suite=0 test=37 name="ws/ABICall (reth)"
INFO[05-16|00:27:02] API: test started                        suite=0 test=38 name="ws/ABITransact (reth)"
INFO[05-16|00:27:02] API: test ended                          suite=0 test=37 pass=false
INFO[05-16|00:28:02] API: test ended                          suite=0 test=32 pass=false
INFO[05-16|00:28:02] API: test ended                          suite=0 test=30 pass=false
INFO[05-16|00:28:02] API: test ended                          suite=0 test=33 pass=false
...

This causes the rpc action to run until timeout:
https://github.com/paradigmxyz/reth/actions/runs/4986338461/jobs/8927243808

Steps to reproduce

Run hive with the ethereum/rpc target:

./hive --client reth --sim "ethereum/rpc"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@Rjected Rjected added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled A-rpc Related to the RPC implementation C-test A change that impacts how or what we test and removed S-needs-triage This issue needs to be labelled labels May 17, 2023
@Rjected
Copy link
Member Author

Rjected commented May 17, 2023

Only the http/ABICall and ws/ABICall tests fail locally, I cannot reproduce the timeout:

INFO[05-17|00:01:41] API: test started                        suite=0 test=13 name="http/ABICall (reth)"
... more logs
INFO[05-17|00:01:41] API: test ended                          suite=0 test=13 pass=false
INFO[05-17|00:01:48] API: test started                        suite=0 test=38 name="ws/ABICall (reth)"
... more logs
INFO[05-17|00:01:48] API: test ended                          suite=0 test=38 pass=false

@Rjected Rjected changed the title Hive rpc tests: websocket tests fail and time out Hive rpc tests: websocket tests fail and time out in CI May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant