Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong is valid if branch #2831

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: wrong is valid if branch #2831

merged 1 commit into from
May 25, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented May 25, 2023

Closes #2704

the if and else branch were switched, only set idle if valid, else trigger sync.

this would prevent a pipeline fallback if the downloader failed.

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine labels May 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #2831 (824dd43) into main (2305310) will increase coverage by 12.43%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main    #2831       +/-   ##
===========================================
+ Coverage   47.31%   59.74%   +12.43%     
===========================================
  Files         505      505               
  Lines       66162    66168        +6     
===========================================
+ Hits        31305    39533     +8228     
+ Misses      34857    26635     -8222     
Flag Coverage Δ
integration-tests 17.40% <0.00%> (+<0.01%) ⬆️
unit-tests 54.03% <0.00%> (+13.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 77.58% <0.00%> (+33.62%) ⬆️
crates/consensus/beacon/src/engine/sync.rs 77.51% <0.00%> (-2.32%) ⬇️

... and 259 files with indirect coverage changes

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@mattsse mattsse merged commit ac8d6f0 into main May 25, 2023
@mattsse mattsse deleted the matt/fix-wrong-if-branch branch May 25, 2023 12:23
shekhirin pushed a commit that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hive rpc tests: websocket tests fail and time out in CI
3 participants