Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename downloaders #1108

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Rename downloaders #1108

merged 5 commits into from
Feb 1, 2023

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Jan 31, 2023

Closes #1076

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #1108 (c199074) into main (5c32ad0) will increase coverage by 0.05%.
The diff coverage is 82.75%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   74.63%   74.69%   +0.05%     
==========================================
  Files         323      323              
  Lines       34956    34998      +42     
==========================================
+ Hits        26089    26141      +52     
+ Misses       8867     8857      -10     
Flag Coverage Δ
unit-tests 74.69% <82.75%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/node/mod.rs 0.00% <0.00%> (ø)
bin/reth/src/stage/mod.rs 0.00% <0.00%> (ø)
crates/stages/src/lib.rs 100.00% <ø> (ø)
...tes/net/downloaders/src/headers/reverse_headers.rs 76.14% <84.61%> (ø)
crates/net/downloaders/src/bodies/bodies.rs 87.87% <100.00%> (ø)
crates/net/downloaders/src/bodies/task.rs 95.78% <100.00%> (ø)
crates/net/downloaders/src/headers/task.rs 85.10% <100.00%> (ø)
crates/stages/src/stages/headers.rs 94.89% <100.00%> (ø)
crates/net/network/src/manager.rs 48.20% <0.00%> (+0.19%) ⬆️
crates/stages/src/stages/sender_recovery.rs 91.39% <0.00%> (+0.53%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit 0149bde into paradigmxyz:main Feb 1, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 6, 2023
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
@leruaa leruaa deleted the rename_downloaders branch July 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename downloaders
3 participants