Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support skip attribute in RlpEncodable derive macro #1116

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Feb 1, 2023

Closes #1102

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #1116 (e84384b) into main (5c32ad0) will increase coverage by 0.07%.
The diff coverage is 80.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   74.63%   74.71%   +0.07%     
==========================================
  Files         323      326       +3     
  Lines       34956    35173     +217     
==========================================
+ Hits        26089    26279     +190     
- Misses       8867     8894      +27     
Flag Coverage Δ
unit-tests 74.71% <80.76%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/common/rlp-derive/src/lib.rs 88.23% <ø> (ø)
crates/common/rlp-derive/src/utils.rs 71.42% <71.42%> (ø)
crates/common/rlp-derive/src/en.rs 96.80% <88.88%> (+0.10%) ⬆️
crates/common/rlp-derive/src/de.rs 93.58% <100.00%> (+0.16%) ⬆️
crates/primitives/src/peer.rs 47.36% <0.00%> (-15.79%) ⬇️
crates/net/network/src/swarm.rs 61.63% <0.00%> (-0.79%) ⬇️
crates/net/eth-wire/src/types/blocks.rs 94.18% <0.00%> (-0.73%) ⬇️
crates/net/network/src/manager.rs 47.44% <0.00%> (-0.57%) ⬇️
crates/stages/src/stages/bodies.rs 92.68% <0.00%> (-0.45%) ⬇️
crates/net/rpc/src/debug.rs 0.00% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@leruaa
Copy link
Contributor Author

leruaa commented Feb 1, 2023

@mattsse I think This PR can't be merged yet, the skipped fields are still taken into account in RlpMaxEncodedLen

@onbjerg onbjerg marked this pull request as draft February 1, 2023 13:25
@onbjerg
Copy link
Member

onbjerg commented Feb 1, 2023

Converting to a draft, feel free to move out of draft when this is ready for review!

@leruaa
Copy link
Contributor Author

leruaa commented Feb 1, 2023

It's ready to be reviewed 👍

@leruaa leruaa marked this pull request as ready for review February 1, 2023 14:38
@mattsse mattsse merged commit 9f49beb into paradigmxyz:main Feb 1, 2023
literallymarvellous pushed a commit to literallymarvellous/reth that referenced this pull request Feb 6, 2023
…z#1116)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@leruaa leruaa deleted the rlp_encodable_skip_attr branch July 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support skip attribute in RlpEncodable derive macro
4 participants