-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support skip attribute in RlpEncodable derive macro #1116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1116 +/- ##
==========================================
+ Coverage 74.63% 74.71% +0.07%
==========================================
Files 323 326 +3
Lines 34956 35173 +217
==========================================
+ Hits 26089 26279 +190
- Misses 8867 8894 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mattsse I think This PR can't be merged yet, the skipped fields are still taken into account in |
Converting to a draft, feel free to move out of draft when this is ready for review! |
It's ready to be reviewed 👍 |
…z#1116) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Closes #1102