Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scaffold impl of EthFilter API handler #1270

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Feb 10, 2023

Closes #1247

Th previous PR for this issue hasn't been merged, I think I deleted the branch too fast on my side.... Sorry about that.

@leruaa leruaa requested a review from gakonst as a code owner February 10, 2023 11:39
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Feb 10, 2023
@mattsse
Copy link
Collaborator

mattsse commented Feb 10, 2023

oops :)

ty for reopening

@codecov-commenter
Copy link

Codecov Report

Merging #1270 (bd33611) into main (a58cf8a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   76.42%   76.36%   -0.06%     
==========================================
  Files         342      343       +1     
  Lines       38385    38412      +27     
==========================================
- Hits        29334    29333       -1     
- Misses       9051     9079      +28     
Flag Coverage Δ
unit-tests 76.36% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/filter.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/pubsub.rs 0.00% <ø> (ø)
crates/rpc/rpc/src/lib.rs 100.00% <ø> (ø)
crates/net/network/src/peers/manager.rs 82.44% <0.00%> (-0.09%) ⬇️
crates/net/discv4/src/lib.rs 66.41% <0.00%> (-0.08%) ⬇️
crates/net/eth-wire/src/capability.rs 61.32% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit 9a4df50 into paradigmxyz:main Feb 10, 2023
@leruaa leruaa deleted the add_eth_filter_scaffold branch February 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scaffold impl of EthFilter API handler
3 participants