Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run revm-inspectors via CLI hooks #1850

Merged
merged 3 commits into from
Mar 19, 2023
Merged

feat: run revm-inspectors via CLI hooks #1850

merged 3 commits into from
Mar 19, 2023

Conversation

gakonst
Copy link
Member

@gakonst gakonst commented Mar 19, 2023

Allows instantiating the Reth Node execution factory with the InspectorStack and the provided hooks by block/txhash/all/none.

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, would be nice to add some requires/conflicts_with attrs for clap args

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1850 (1deed17) into main (a59806f) will decrease coverage by 0.05%.
The diff coverage is 21.62%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   73.40%   73.36%   -0.05%     
==========================================
  Files         415      415              
  Lines       50555    50590      +35     
==========================================
+ Hits        37110    37113       +3     
- Misses      13445    13477      +32     
Flag Coverage Δ
integration-tests 19.67% <0.00%> (-0.03%) ⬇️
unit-tests 67.72% <21.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/node/mod.rs 3.83% <0.00%> (-0.18%) ⬇️
crates/revm/revm-inspectors/src/stack/mod.rs 9.15% <14.28%> (-0.38%) ⬇️
crates/executor/src/factory.rs 45.83% <46.66%> (-17.81%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit 0b7205d into main Mar 19, 2023
@gakonst gakonst deleted the feat/hook-exec-cli branch March 19, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants