feat(cli): disable persistent logs #2263
Conversation
rkrasiuk
added
C-enhancement
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 70.24% 72.03% +1.78%
==========================================
Files 472 472
Lines 56738 56742 +4
==========================================
+ Hits 39858 40876 +1018
+ Misses 16880 15866 -1014
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 84 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rkrasiuk
changed the title
bin/reth/src/cli.rs
Outdated
| /// The flag to disable persistent logs. | ||
| #[arg(long = "log.disable-persistent", global = true, conflicts_with = "log_directory")] | ||
| disable_persistent: bool, |
There was a problem hiding this comment.
why is this enabled by default?
I didn't even know this was a thing
There was a problem hiding this comment.
idk, don't mind making it disabled by default. the only reason i knew about this is because i kept running out of disk space
There was a problem hiding this comment.
same here, didn't attribute it at first to gigantic logs.
I'm for making this opt in.
|
Need this to unblock debugging at the tip. I think we'll revamp our logging from first principles as right now our logs are less useful for end users and more for our own internal debugging. |
Currently, our logs are really verbose and the log file grows very fast. My machine ran out of disk space during full sync due to the log file growing to 777gb.
Change default behavior to disabled persistent logs. Add an option to enable persistent logs.
This is a temporary solution to a log file size problem. Ideally, we want to have a size limit at which the older logs would be flushed.