Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): add reported bad transactions metric #2270

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Apr 15, 2023

Closes #2258

add new counter for how often we reported on bad transaction

@mattsse mattsse requested a review from Rjected as a code owner April 15, 2023 10:35
@mattsse mattsse added A-observability Related to tracing, metrics, logs and other observability tools A-networking Related to networking in general labels Apr 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2270 (0e8c6d5) into main (ec097fa) will increase coverage by 1.31%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   70.75%   72.06%   +1.31%     
==========================================
  Files         472      472              
  Lines       56721    56722       +1     
==========================================
+ Hits        40132    40877     +745     
+ Misses      16589    15845     -744     
Flag Coverage Δ
integration-tests 18.38% <0.00%> (+2.24%) ⬆️
unit-tests 67.11% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/network/src/metrics.rs 59.09% <ø> (+13.63%) ⬆️
crates/net/network/src/transactions.rs 52.26% <0.00%> (-0.10%) ⬇️

... and 51 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit ca70d73 into main Apr 16, 2023
@gakonst gakonst deleted the matt/add-reported-bad-tx-counter branch April 16, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a metric for total number of times peers have been reported for bad messages
3 participants