Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sealed_header to HeaderProvider for single headers #2801

Merged
merged 2 commits into from
May 23, 2023
Merged

feat: add sealed_header to HeaderProvider for single headers #2801

merged 2 commits into from
May 23, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented May 23, 2023

motivated by #2707
ref #2769

Adds a sealed_header method for retrieving just a single sealed header from the db.

@Rjected Rjected added C-enhancement New feature or request A-rpc Related to the RPC implementation A-db Related to the database labels May 23, 2023
@Rjected Rjected mentioned this pull request May 23, 2023
Merged
mattsse
mattsse approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

there are a few additional impls of this trait

@Rjected
Copy link
Member Author

Rjected commented May 23, 2023

whoops missed an impl I think? fixing tests

@Rjected Rjected requested a review from gakonst as a code owner May 23, 2023 19:28
@Rjected Rjected merged commit 5039122 into main May 23, 2023
@Rjected Rjected deleted the dan/sealed-header-provider branch May 23, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-db Related to the database A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse