Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes RPC server settings configurable #2814

Merged

Conversation

ecivini
Copy link
Contributor

@ecivini ecivini commented May 24, 2023

This PR solves issue #2560.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ty!

@mattsse mattsse added the A-rpc Related to the RPC implementation label May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #2814 (1440b7c) into main (df82387) will decrease coverage by 11.77%.
The diff coverage is 7.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main    #2814       +/-   ##
===========================================
- Coverage   71.41%   59.64%   -11.77%     
===========================================
  Files         505      505               
  Lines       65834    65846       +12     
===========================================
- Hits        47013    39277     -7736     
- Misses      18821    26569     +7748     
Flag Coverage Δ
integration-tests 17.43% <7.69%> (-0.01%) ⬇️
unit-tests 53.92% <7.69%> (-12.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/eth.rs 50.00% <7.69%> (-42.86%) ⬇️

... and 170 files with indirect coverage changes

@mattsse mattsse merged commit cffdc8d into paradigmxyz:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants