fix(bin): checkpoints comparison in merkle-debug
#2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-bug
rkrasiuk
reviewed
May 24, 2023
bin/reth/src/merkle_debug.rs
Outdated
Comment on lines
73
to
80
| ACCOUNT_HASHING.get_checkpoint(tx.deref())?.unwrap_or_default().block_number && | ||
| execution_checkpoint_block == | ||
| STORAGE_HASHING.get_checkpoint(tx.deref())?.unwrap_or_default().block_number && | ||
| execution_checkpoint_block == | ||
| MERKLE_EXECUTION | ||
| .get_checkpoint(tx.deref())? | ||
| .unwrap_or_default() | ||
| .block_number); |
There was a problem hiding this comment.
we should also make sure that there's no intermediate progress (all the other fields in hashing & merkle checkpoints are None)
There was a problem hiding this comment.
i think it wasn't checked before when we had a separate table for intermediate hashing progress, added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2701, such checkpoint comparison is no longer valid as it now includes stage-specific stuff. We should compare just block numbers instead.