docs: add list of all stages #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
reviewed
May 25, 2023
Comment on lines
+74
to
+76
| /// - [`IndexStorageHistoryStage`] | ||
| /// - [`IndexAccountHistoryStage`] |
There was a problem hiding this comment.
you missed TransactionLookup & Finish stages
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2826 +/- ##
==========================================
+ Coverage 71.39% 71.41% +0.02%
==========================================
Files 505 505
Lines 66142 66142
==========================================
+ Hits 47219 47238 +19
+ Misses 18923 18904 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
force-pushed
the
matt/add-list-of-stages
branch
from
1437bb7
to
539f779
Compare
onbjerg
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2254
I keep forgetting the order of stages.
🤖 Generated by Copilot at 1437bb7
This pull request adds documentation comments to the
Stagestrait and theDefaultStagesstruct in thestagescrate. These comments clarify the role and functionality of the pipeline stages that reth uses to sync with the Ethereum network.