feat(stages): merkle execute stage progress #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/merkle-progress
branch
3 times, most recently
from
1845914
to
4cb1e26
Compare
shekhirin
force-pushed
the
feat/checkpoints
branch
from
db8c2b1
to
2d64dac
Compare
shekhirin
force-pushed
the
alexey/merkle-progress
branch
from
4cb1e26
to
8617a8d
Compare
shekhirin
force-pushed
the
alexey/merkle-progress
branch
from
f2bdba5
to
d627a7f
Compare
shekhirin
changed the title
shekhirin
added
C-enhancement
onbjerg
approved these changes
May 29, 2023
shekhirin
added a commit
that referenced
this pull request
May 30, 2023
shekhirin
added a commit
that referenced
this pull request
May 30, 2023
shekhirin
added a commit
that referenced
this pull request
May 30, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
shekhirin
added a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report progress for
MerkleExecutestage based on the number of hashed accounts and storage slots processed vs total in database. For example, this is Sepolia Merkle stage execution after being dropped manually using CLI:This PR doesn't have any breaking DB changes, as we don't need to introduce any additional checkpoint models.
Further work is to calculate a similar progress for
MerkleUnwind, but currently not clear how to report it in metrics, so we could see one commonMerklestage chart going up when executing, and down when unwinding.