Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): integrate max tracing requests in cli #2914

Merged
merged 1 commit into from
May 30, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented May 30, 2023

integrate the max_tracing_requests in cli

🤖 Generated by Copilot at a6a6e5b

Increased the tracing limit and improved the tracing API in the rpc and rpc-builder crates. Refactored some builder methods and added documentation and type annotations to the TracingCallGuard struct.

@mattsse mattsse added A-rpc Related to the RPC implementation A-cli Related to the reth CLI labels May 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2914 (a6a6e5b) into main (3347da0) will decrease coverage by 0.06%.
The diff coverage is 61.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   71.15%   71.10%   -0.06%     
==========================================
  Files         515      515              
  Lines       66723    66729       +6     
==========================================
- Hits        47478    47445      -33     
- Misses      19245    19284      +39     
Flag Coverage Δ
integration-tests 17.38% <15.38%> (-0.02%) ⬇️
unit-tests 65.98% <46.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/eth.rs 65.38% <50.00%> (+15.38%) ⬆️
bin/reth/src/args/rpc_server_args.rs 47.82% <57.14%> (+0.04%) ⬆️
crates/rpc/rpc/src/call_guard.rs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit c481b87 May 30, 2023
@mattsse mattsse deleted the matt/integrate-max-tracing-in-cli branch May 30, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants