Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integrate cache config in rpc args #2924

Merged
merged 3 commits into from
May 31, 2023
Merged

feat: Integrate cache config in rpc args #2924

merged 3 commits into from
May 31, 2023

Conversation

chirag-bgh
Copy link
Contributor

Closes #2915

mattsse
mattsse requested changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

sorry, I forgot to outline in the issue that the args should accept MB not bytes, for convenience

bin/reth/src/args/rpc_server_args.rs Outdated Show resolved Hide resolved
@mattsse mattsse added A-rpc Related to the RPC implementation A-cli Related to the reth CLI labels May 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #2924 (c9fd214) into main (5d7eba6) will decrease coverage by 9.69%.
The diff coverage is 30.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
- Coverage   71.14%   61.46%   -9.69%     
==========================================
  Files         515      515              
  Lines       66723    66741      +18     
==========================================
- Hits        47470    41022    -6448     
- Misses      19253    25719    +6466
Flag Coverage Δ
integration-tests 17.38% <15.00%> (-0.02%) ⬇️
unit-tests 56.08% <30.00%> (-9.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/args/rpc_server_args.rs 46.17% <17.64%> (-1.65%) ⬇️
crates/rpc/rpc/src/eth/cache.rs 67.85% <100.00%> (ø)

... and 136 files with indirect coverage changes

@onbjerg
Copy link
Member

onbjerg commented May 31, 2023

needs to be rebased for CI to work

mattsse
mattsse approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg enabled auto-merge May 31, 2023 13:08
@onbjerg onbjerg added this pull request to the merge queue May 31, 2023
Merged via the queue into paradigmxyz:main with commit c4764d4 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate cache config in rpc args
4 participants
@chirag-bgh @codecov-commenter @onbjerg @mattsse