Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add rpc_ namespace #2928

Merged
merged 5 commits into from
Jun 2, 2023
Merged

feat(rpc): add rpc_ namespace #2928

merged 5 commits into from
Jun 2, 2023

Conversation

TechieBoy
Copy link
Contributor

Closes #2923

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

a few suggestions

crates/rpc/rpc-api/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/rpc.rs Show resolved Hide resolved
crates/rpc/rpc-types/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/rpc.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #2928 (9ffb4c6) into main (6353792) will decrease coverage by 0.08%.
The diff coverage is 56.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
- Coverage   71.09%   71.01%   -0.08%     
==========================================
  Files         517      520       +3     
  Lines       67083    67117      +34     
==========================================
- Hits        47692    47664      -28     
- Misses      19391    19453      +62     
Flag Coverage Δ
integration-tests 17.29% <13.63%> (-0.03%) ⬇️
unit-tests 65.91% <43.18%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-api/src/lib.rs 100.00% <ø> (ø)
crates/rpc/rpc-api/src/rpc.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/lib.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/lib.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/rpc.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-builder/src/lib.rs 68.45% <46.66%> (-0.37%) ⬇️
crates/rpc/rpc-types/src/rpc.rs 85.71% <85.71%> (ø)

... and 17 files with indirect coverage changes

@onbjerg onbjerg added A-rpc Related to the RPC implementation C-enhancement New feature or request labels May 31, 2023
@TechieBoy TechieBoy requested a review from mattsse June 2, 2023 10:11
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome tysm for this!

I only changed the naming and made the return type not an Arc

@mattsse mattsse enabled auto-merge June 2, 2023 10:26
@mattsse mattsse added this pull request to the merge queue Jun 2, 2023
Merged via the queue into paradigmxyz:main with commit 5b72a73 Jun 2, 2023
@TechieBoy TechieBoy deleted the rpc_api branch June 3, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rpc_ namespace
4 participants