docs: use nightly clippy in vscode #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this small fix, I had a bunch of Clippy warnings/errors on VS Code.
|
Wait, actually, it's not working well |
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 73.25% 73.32% +0.07%
==========================================
Files 278 278
Lines 29282 29282
==========================================
+ Hits 21450 21472 +22
+ Misses 7832 7810 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
onbjerg
added
C-test
onbjerg
requested changes
Jan 13, 2023
Comment on lines
+93
to
+100
| "rust-analyzer.checkOnSave.overrideCommand": [ | ||
| "cargo", | ||
| "+nightly", | ||
| "clippy", | ||
| "--all", | ||
| "--all-features", | ||
| "--message-format=json" | ||
| ], |
There was a problem hiding this comment.
Suggested change
| "rust-analyzer.checkOnSave.overrideCommand": [ | |
| "cargo", | |
| "+nightly", | |
| "clippy", | |
| "--all", | |
| "--all-features", | |
| "--message-format=json" | |
| ], | |
| "rust-analyzer.checkOnSave.command": "clippy", | |
| "rust-analyzer.checkOnSave.features": "all", | |
| "rust-analyzer.checkOnSave.extraArgs": ["+nightly"], |
There was a problem hiding this comment.
It not working for me:
[ERROR flycheck] Flycheck failed to run the following command: "cargo" "check" "--workspace" "--message-format=json" "--manifest-path" "/workspaces/crypto/learn/ethereum/reth/reth/Cargo.toml" "--all-targets" "+nightly"
[ERROR rust_analyzer::lsp_utils] cargo check failed
Cargo watcher failed, the command produced no valid metadata (exit code: ExitStatus(unix_wait_status(256))):
error: Found argument '+nightly' which wasn't expected, or isn't valid in this context
There was a problem hiding this comment.
Sorry, add rust-analyzer.checkOnSave.command to clippy as well. Updated my suggestion to include the new things
There was a problem hiding this comment.
Hmmm I have a similar error:
[ERROR flycheck] Flycheck failed to run the following command: "cargo" "clippy" "--workspace" "--message-format=json" "--manifest-path" "/workspaces/crypto/learn/ethereum/reth/reth/Cargo.toml" "--all-targets" "--all-features" "+nightly"
[ERROR rust_analyzer::lsp_utils] cargo check failed
Cargo watcher failed, the command produced no valid metadata (exit code: ExitStatus(unix_wait_status(256))):
error: Found argument '+nightly' which wasn't expected, or isn't valid in this context
There was a problem hiding this comment.
Alright, strange. This is fine then, thank you for being patient!
onbjerg
added
C-docs
onbjerg
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this small fix, I had a bunch of Clippy warnings/errors on VS Code.