Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate fork_id before adding peer from discovery #871

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: validate fork_id before adding peer from discovery #871

merged 1 commit into from
Jan 13, 2023

Conversation

TechieBoy
Copy link
Contributor

Closes #864

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior A-networking Related to networking in general A-discv4 Related to discv4 discovery labels Jan 13, 2023
mattsse
mattsse approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit weird that we have to propagate the event up one level in order to check the forkid.

but I don't want to have it in two places, so this is fine, considered that we already do this with the enr forkid event

@mattsse mattsse merged commit 5c80bc9 into paradigmxyz:main Jan 13, 2023
@TechieBoy TechieBoy deleted the forkid-validate branch January 14, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-discv4 Related to discv4 discovery A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate ForkId when present in Discovered event
3 participants
@TechieBoy @mattsse @onbjerg