-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to (de)serialize NetworkConfigBuilder #897
Conversation
Still need to make a bunch of things (De)Serializable. Added some |
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 73.93% 73.99% +0.05%
==========================================
Files 288 288
Lines 30786 30782 -4
==========================================
+ Hits 22763 22777 +14
+ Misses 8023 8005 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
Made some progress, some things to notice:
Thanks in advance for your feedbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty,
some early pointers.
@leruaa this is looking great -just a bunch of merge conflicts to address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #873