Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text encoding flags #3062

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

HackbrettXXX
Copy link
Collaborator

Fixes the options.flags parameter for the text method. Since 2.0.0, this parameter had no effect and, as a consequence, the defaults were wrong. This is a regression to 1.5.3 and lead to issues like #2832.

The defaults are now once again:

{
  autoencode: true,
  noBOM: true
}

Fixes #2832.

@HackbrettXXX HackbrettXXX merged commit 102f370 into parallax:master Jan 15, 2021
@HackbrettXXX HackbrettXXX deleted the fix-text-encoding-flags branch January 15, 2021 14:25
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Copy link

@marosca marosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this pr!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special char not recognized and text illegible in a PDF generated with jspdf and html2canvas
2 participants