Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update foreign asset location construction #377

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

marshacb
Copy link
Contributor

@marshacb marshacb commented Mar 1, 2024

Description

This PR fixes a bug where foreign asset locations had their PalletInstance prepended to them.
This is incorrect behavior which should be removed.

Changes

  • removes constructForeignAssetMultilocation function from the API
  • adds additional foreign asset examples for local, reserve and teleport txs
  • fixes test in resolveMultiLocation to require the correct xcm version for the GlobalConsensus type

closes: #376

add foreign asset transfer to examples for polkadot and kusama
…tance junction added

adds examples for kusama and polkadot foreign asset tx construction
@marshacb marshacb marked this pull request as ready for review March 1, 2024 20:40
@marshacb marshacb requested a review from bee344 March 1, 2024 22:12
Copy link
Contributor

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@marshacb marshacb merged commit 9c6cbc1 into main Mar 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: remove pallet instance from foreign asset construction
2 participants