Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update paysWithFeeOrigin examples and errors #420

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

marshacb
Copy link
Contributor

@marshacb marshacb commented Jul 2, 2024

Changes

This PR removes legacy functionality which allowed for sufficient assets to be used with the paysWithFeeOrigin option. Now only valid asset locations, symbols or integer IDs are able to be passed into paysWithFeeOrigin. Non unique and invalid values will throw an error.

  • added ability to provide asset symbols (e.g. usdt) and asset integer IDs (e.g. 1984) as values to paysWithFeeOrigin. The asset location in these cases is derived by the API if valid.

closes: #419

@marshacb marshacb requested review from TarikGul and bee344 July 2, 2024 20:03
@marshacb marshacb merged commit 7eb9ce9 into main Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paysWithFeeOrigin? optional input seems to be broken
2 participants