Companion for #7005 #2433
Companion for #7005 #2433
Conversation
gilescope
added
A0-please_review
|
need to do contracts and collectives too. |
(talking to yourself is the first sign of madness)
Contracts rococo was importing kusama constants rather than rococo constants. Have corrected this.
|
PR should be updated to not use statemint. |
|
bot rebase |
|
Rebased |
| let self_para_id: u32 = parachain_info::Pallet::<Runtime>::get().into(); | ||
| if let MultiLocation { parents: 0, interior: X1(Parachain(para_id)) } = l { | ||
| if *para_id == self_para_id { | ||
| return false |
There was a problem hiding this comment.
here should be probably return true, because we want to waive runtime itself not to pay fees (used for XcmFeesToAccount),
with return false runtime itself wont be waived, means it needs to pay
other question is if matching of MultiLocation { parents: 0, interior: X1(Parachain(para_id)) shouldnt be replaced with Here or better just remove this if for self-detection
There was a problem hiding this comment.
I think we avoided matching ourself for the asset-conversion because we started trying to asset transfer native assets - we have explicit checks in the asset-coversion pallet now so I don't think this exception is now needed.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Companion for paritytech/polkadot#7005