Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add test-utils feature to polkadot-node-core-pvf #2989

Conversation

jpserrat
Copy link
Contributor

@jpserrat jpserrat commented Aug 9, 2023

Companion for paritytech/polkadot#7538

@jpserrat jpserrat changed the title add test-utils feature to polkadot-node-core-pvf Cumulus companion: paritytech/polkadot#7538 Aug 9, 2023
@jpserrat jpserrat changed the title Cumulus companion: paritytech/polkadot#7538 add test-utils feature to polkadot-node-core-pvf Aug 9, 2023
@jpserrat
Copy link
Contributor Author

@mrcnski @slumber Cumulus companion created.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "push" "Jpserrat" "jpserrat-add-test-utils-companion", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/Jpserrat/cumulus.git
! [remote rejected] jpserrat-add-test-utils-companion -> jpserrat-add-test-utils-companion (refusing to allow a GitHub App to create or update workflow .github/workflows/release-10_rc-automation.yml without workflows permission)
error: failed to push some refs to 'https://github.com/Jpserrat/cumulus.git'

@mrcnski
Copy link
Contributor

mrcnski commented Aug 14, 2023

Agh! I'll try to fix your companion. Luckily companions won't be a thing anymore soon.

@mrcnski mrcnski added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 14, 2023
@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

Green now. Can we merge to unblock the CI?

Cargo.lock Outdated Show resolved Hide resolved
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something with the update is wrong with the cargo update. It should be -+300 lines, not 2200.

@mrcnski
Copy link
Contributor

mrcnski commented Aug 14, 2023

@ggwpez What command should I run? I'm getting

$ cargo update
    Updating crates.io index
    Updating git repository `https://github.com/paritytech/substrate`
    Updating git repository `https://github.com/paritytech/polkadot`
error: no matching package named `pallet-multisig` found
location searched: https://github.com/paritytech/substrate?branch=master
required by package `asset-hub-kusama-runtime v0.9.420 (/Users/parity/Repos/github.com/paritytech/cumulus-2/parachains/runtimes/assets/asset-hub-kusama)`

@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

Need this first, there is some upstream problem in Substrate master paritytech/substrate#14763

@mrcnski
Copy link
Contributor

mrcnski commented Aug 14, 2023

Got it thanks. Hopefully this is the last companion I ever have to merge. 😄

mrcnski and others added 4 commits August 14, 2023 13:51
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the last updates, this is roughly how it should look like; not +-2200.

image

@mrcnski
Copy link
Contributor

mrcnski commented Aug 14, 2023

Thanks @ggwpez! I had tried reverting Cargo.lock then cargo update, but guess I messed up something.

@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 5e6ee34 into paritytech:master Aug 14, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants