Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Implement Asset Teleport for Statemint #504

Closed
wants to merge 6 commits into from
Closed

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Jun 23, 2021

This PR implements asset teleports from one instance of Statemint to another.

Open questions:

  • What should be the policy for sending and receiving teleports for Statemint?
  • When/Where does the conversion to the local asset schema happen? (This implementation just maps asset ids to one another directly, i.e. asset(42) on one instance is asset(42) on the other.)

depends on paritytech/polkadot#3345

@@ -208,7 +208,7 @@ where

let mut block_import_params = BlockImportParams::new(BlockOrigin::Own, header);
block_import_params.body = Some(extrinsics);
block_import_params.storage_changes = Some(storage_changes);
// block_import_params.storage_changes = Some(storage_changes);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick fix to be able to use update Substrate
TODO: remove (probably by pulling in master)

@apopiak apopiak added the T7-system_parachains This PR/Issue is related to System Parachains. label Jun 24, 2021
@xlc
Copy link
Contributor

xlc commented Jun 24, 2021

What's the use case for this? You can't teleport assets to relaychain. You can't teleport assets to other non system/common good parachains. I don't see any plans to have another system/common good parachain.

On the other hand, reserved based transfer is required to support assets transfer to other community parachains.

@apopiak
Copy link
Contributor Author

apopiak commented Jun 25, 2021

Mmmh, I would've thought that there will be support for transfer to community parachains (on the parachains' side).
You guys won't support teleport from Statemint?
You think that's only feasible via reserve based transfer?

@xlc
Copy link
Contributor

xlc commented Jun 25, 2021

I am pretty sure @gavofyork said somewhere teleport is between trusted chains only and community parachain won’t be a trusted chain of system/common good/relaychain. So not we don’t want to support it, but for security purpose Statemine shouldn’t support it. Otherwise how could you prevent a community chain just mint extra assets and transfer back to Statemine?

@gavofyork
Copy link
Member

Precisely. There should be no changes to Statemine regarding teleports at present.

@gavofyork gavofyork closed this Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants