-
Notifications
You must be signed in to change notification settings - Fork 380
Implement Asset Teleport for Statemint #504
Conversation
@@ -208,7 +208,7 @@ where | |||
|
|||
let mut block_import_params = BlockImportParams::new(BlockOrigin::Own, header); | |||
block_import_params.body = Some(extrinsics); | |||
block_import_params.storage_changes = Some(storage_changes); | |||
// block_import_params.storage_changes = Some(storage_changes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick fix to be able to use update Substrate
TODO: remove (probably by pulling in master)
What's the use case for this? You can't teleport assets to relaychain. You can't teleport assets to other non system/common good parachains. I don't see any plans to have another system/common good parachain. On the other hand, reserved based transfer is required to support assets transfer to other community parachains. |
Mmmh, I would've thought that there will be support for transfer to community parachains (on the parachains' side). |
I am pretty sure @gavofyork said somewhere teleport is between trusted chains only and community parachain won’t be a trusted chain of system/common good/relaychain. So not we don’t want to support it, but for security purpose Statemine shouldn’t support it. Otherwise how could you prevent a community chain just mint extra assets and transfer back to Statemine? |
Precisely. There should be no changes to Statemine regarding teleports at present. |
This PR implements asset teleports from one instance of Statemint to another.
Open questions:
asset(42)
on one instance isasset(42)
on the other.)depends on paritytech/polkadot#3345