This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Integrate try-runtime into cumulus #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Nov 24, 2021
apopiak
reviewed
Nov 26, 2021
apopiak
suggested changes
Nov 30, 2021
Have you seen https://paritytech.github.io/substrate/master/try_runtime_cli/enum.Command.html and https://paritytech.github.io/substrate/master/try_runtime_cli/index.html? |
apopiak
reviewed
Nov 30, 2021
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
kianenigma
commented
Nov 30, 2021
|
I believe we're in good shape now. |
|
@bkchr @paritytech/ci are you okay with the CI changes? |
kianenigma
commented
Dec 2, 2021
| } | ||
| impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ext(), crate::mock::Test, extra = false,); |
There was a problem hiding this comment.
This could never work and was not compiling in the first place either, because the mock of pallet_session cannot be used here.
bkchr
approved these changes
Dec 2, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parachain teams can now use this to (somewhat) easily test their migrations (or other shenanigans) of live chains using the cumulus client.
Example:
Also needed by @apopiak for runtime upgrade testing of Statemine (and Statemint in the future).
Also needed for paritytech/substrate#10073
--features try-runtimeas well.