-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Additional variables for benchmarks execution #884
Conversation
I suggest to make slow stuff I need to refactor the benches to be faster but the bad the thing is that we can't compare with the old data then :( See #885 I still think 3h is way too long. |
If we consider some data not accurate maybe it's not that bad?
But why? Because for local run it's too long? |
Probably yes, but I can try backporting the benches to the "most recent" releases to have some data compare against at least.
Yeah or unnecessary load on the benchmarks itself, we are testing with some extreme limits such a I think we can relax the |
Also it's possible to run benchmarks with |
I just merged #885 but I think we should try with MEASUREMENT_TIME=10 to begin with it's just used a two benches now. |
Okay, I'd like to wait https://gitlab.parity.io/parity/mirrors/jsonrpsee/-/pipelines/217578 to check how long the benches will take with this settings. If the job succeeds I'll merge this PR |
Added
MEASUREMENT_TIME: 3
andSLOW_MEASUREMENT_TIME: 40
variables to benchmark job. With these variables it takes ~2h to run benchmarks: https://gitlab.parity.io/parity/mirrors/jsonrpsee/-/jobs/1885548cc https://github.com/paritytech/ci_cd/issues/302