Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monorepo labels draft #29

Merged
merged 18 commits into from
Aug 25, 2023
Merged

monorepo labels draft #29

Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a381db5
monorepo labels draft
the-right-joyce May 9, 2023
9f39fd0
update date
the-right-joyce May 9, 2023
f8a2483
update
the-right-joyce May 12, 2023
8a2a8e1
Update
the-right-joyce May 19, 2023
e0b6cc9
Update A* labels
the-right-joyce May 19, 2023
9c533b2
delete C5-reserved
the-right-joyce May 19, 2023
e8ee30b
update R&D label
the-right-joyce May 19, 2023
e721d65
add system parachains to topics
the-right-joyce May 20, 2023
b5b5ae6
update topics
the-right-joyce May 20, 2023
639ff28
update colors
the-right-joyce May 30, 2023
b6deabd
delete B* labels
the-right-joyce Jun 13, 2023
3a49ccd
added contribution labels, deleted B* labels, updated complexity labels
the-right-joyce Jul 4, 2023
4546eed
Merge branch 'the-right-joyce-monorepo-labels' of https://github.com/…
the-right-joyce Jul 4, 2023
d82d201
delete ready for review label
the-right-joyce Jul 5, 2023
51cdad6
add T1 FRAME, T2 Pallets, T11 Cumulus
the-right-joyce Jul 27, 2023
c620537
add version, fix indent
alvicsam Jul 31, 2023
c741d8b
add test rule
alvicsam Jul 31, 2023
eb1a3a8
update file name
the-right-joyce Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 175 additions & 0 deletions ruled_labels/[DRAFT]specs_monorepo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@

name: Monorepo labels
description: Import on 2023-05-09

codes:
- code: A
name: Action
description: used with GHA and trigger a certain process
- code: B
name: Breaking changes
description: Upgrade dependencies, relevant for downstream Parachains/Parathreads.
- code: C
name: Complexity
description: Complexity of the issues, also used for contribution guidelines.
- code: D
name: Auditing
description: Required when there were changes in the paths [CI/CD INPUT NEW FILE PATHS]. Also used to indicate the need for a documentation audit of DevRel.
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
- code: I
name: Issues
description: Categorisation of issues
- code: T
name: Topics
description: PR/Issue is related to this topic
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved

labels:
- name: A0-please_review
description: Pull request needs code review.
color: "666666"
- name: A1-needs_burnin
description: Pull request needs to be tested on a live validator node before merge. DevOps team is notified via matrix.
color: c7def8
- name: A2-insubstantial
description: Pull request requires no code review (e.g., a sub-repository hash update).
color: C6C7F8
- name: A3-in_progress
description: Pull request is in progress. No review needed at this stage.
color: DBC6F8
- name: A4-stale
description: Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
color: F2C5F8
- name: A5-backport
description: Pull request is already reviewed well in another branch.
color: F8C5E7
- name: B0-runtime_migration
description: PR introduces code that might require downstream chains to run a runtime upgrade.
color: c2e0c6
- name: B1-database_migration
description: PR introduces code that does a one-way migration of the database.
color: f4f5f9
- name: B2-node_first_update
description: This is a runtime change that will require all nodes to be update BEFORE the runtime upgrade.
color: e8d7d7
- name: B3-add_new_host_function_to_client
description: PR adds a new host function to the client which is not yet used by the runtime.
color: f9f2f2
- name: B4-use_previously_unused_host_function_in_runtime
description: PR modifies the runtime to use a new host function; this raises the minimum client node version requirement for the next runtime upgrade!
color: f9f2f2
- name: B5-unused_host_function_breaking_change
description: PR introduces a breaking change to the behavior of a host function which is not used by any runtime.
color: f9f2f2
- name: B6-remove_unused_host_function
description: PR removes a host function not used by any runtime.
color: f9f2f2
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
- name: B7-breaking_change_RPC_API
description: This PR this changes the behavior of the external RPC API in a backwards incompatible way.
color: cdadad
- name: C0-easy
description: Can be fixed primarily by duplicating and adapting code by an intermediate coder.
color: eeeeee
- name: C1-medium
description: Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
color: eebb00
- name: C2-substantial
description: Can be fixed by an experienced coder with a working knowledge of the codebase.
color: D4C5F9
- name: C3-involved
description: Can be fixed by an expert coder with good knowledge of the codebase.
color: E99695
- name: C4-mentor
description: An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
color: "5319e7"
- name: C5-reserved
description: This issue should not be picked up by anyone unless approved.
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
color: cdadad
- name: D0-nice_to_have_audit
description: PR contains trivial changes to logic that should be properly reviewed.
color: c5def5
- name: D1-needs_audit
description: PR contains changes to fund-managing logic that should be properly reviewed and externally audited.
color: C3EDC0
- name: D2-needs_DevRel_audit
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
description: PR contains changes that are relevant for documentation, should be audited by DevRel before merge.
color: C0E7CC
- name: D3-audited
description: PR contains changes to fund-managing logic that has been properly reviewed and externally audited.
color: C0E7CC
- name: I0-panic
description: The node panics and exits without proper error handling.
color: 17b25d
- name: I1-security
description: The node fails to follow expected, security-sensitive, behaviour.
color: d93f0b
- name: I2-bug
description: The node fails to follow expected behavior.
color: "249899"
- name: I3-annoyance
description: The node behaves within expectations, however this “expected behaviour” itself is at issue.
color: D6075D
- name: I4-refactor
description: Code needs refactoring.
color: 0075ca
- name: I5-enhancement
description: An additional feature request.
color: c2e0c6
- name: I6-meta
description: A specific issue for grouping tasks or bugs of a specific category.
color: a2eeef
- name: I7-duplicate
description: Issue is a duplicate. Closer should comment with a link to the duplicate.
color: D62209
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
- name: I8-wont_fix
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
description: Issue is in principle valid, but this project will not address it. Closer should explain why.
color: FB3701
- name: I9-invalid
description: Issue is invalid. Closer should comment why.
color: F76E02
- name: I10-optimisation
description: An enhancement to provide better overall performance in terms of time-to-completion for a task.
color: c5def5
the-right-joyce marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have two labels here: one for CPU optimization, and one for memory usage optimizations.

Copy link
Collaborator Author

@the-right-joyce the-right-joyce May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be enough if you use I10-optimisation with a T* label? Then I'd add there T12-CPU and T13-memory_usage? And you can then mix and match with other labels, like: bug, annoyance, etc.

- name: I11-unconfirmed
description: Issue might be valid, but it's not yet known.
color: "000000"
- name: I12-deprecation
description: The current issue/pr is, or should be, part of a deprecation process.
color: "000000"
- name: T0-node
description: This PR/Issue is related to the topic “node”.
color: fbffe0
- name: T1-runtime
description: This PR/Issue is related to the topic “runtime”.
color: F5FCE6
- name: T2-RPC_API
description: This PR/Issue is related to RPC APIs.
color: 009B40
- name: T3-runtime_API
description: This PR/Issue is related to runtime APIs.
color: 009B40
- name: T4-host_functions
description: This PR/Issue is related to host functions.
color: 009B40
- name: T5-XCM
description: This PR/Issue is related to XCM.
color: 006b75
- name: T6-smart_contracts
description: This PR/Issue is related to smart contracts.
color: 0C7BAD
- name: T7-parachains_engineering
description: This PR/Issue is related to Parachains performance, stability, maintenance.
color: 0052cc
- name: T8-parachains_protocol
description: This PR/Issue is related to Parachains features and protocol changes.
color: 5319e7
- name: T9-polkadot
description: This PR/Issue is related to/affects Polkadot.
color: ffeeee
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to specify this here more? like: relay chain, collators, staking, etc.?

- name: T10-tests
description: This PR/Issue is related to tests.
color: 6C9C98
- name: T11-documentation
description: This PR/Issue is related to documentation.
color: f48a75
ggwpez marked this conversation as resolved.
Show resolved Hide resolved
- name: T12-benchmarks
description: This PR/Issue is related to benchmarking and weights.
color: 5319e7