Add bytes::Bytes implementation #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorot93
force-pushed
the
bytes
branch
3 times, most recently
from
de64dd7
to
ba5a2e5
Compare
bkchr
reviewed
Jan 11, 2022
|
@bkchr I reworked the PR to make use of WrapperTypeEncode and EncodeLike, just the way SCALE is implemented for String and memory containers. Also added tests. |
|
Any chance this could be merged soon? @bkchr |
bkchr
reviewed
Jan 22, 2022
|
Ty for fixing the ui test! |
bkchr
approved these changes
Jan 23, 2022
|
@vorot93 if you post your polkadot or kusama address, I will open a treasury tip for you |
|
@shawntabrizi Sure
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
polkadot address: 15rc4P2NQ3zuzk2r3RYyYtYmCV7aeMGbRdEHxrT2UNdJQpfr