Skip to content

Commit

Permalink
migrate benchmarking for proxy pallet
Browse files Browse the repository at this point in the history
  • Loading branch information
@re-gius
re-gius committed Oct 10, 2024
1 parent a4b1fd2 commit bf177fc
Showing 1 changed file with 108 additions and 66 deletions.
174 changes: 108 additions & 66 deletions substrate/frame/proxy/src/benchmarking.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
use super::*;
use crate::Pallet as Proxy;
use alloc::{boxed::Box, vec};
#[allow(deprecated)]
use frame::benchmarking::v1::*;
use frame::benchmarking::v2::*;

const SEED: u32 = 0;

Expand Down Expand Up @@ -79,24 +78,33 @@ fn add_announcements<T: Config>(
Ok(())
}

benchmarks! {
proxy {
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
#[benchmarks]
mod benchmarks {
use super::*;

#[benchmark]
fn proxy(p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
// In this case the caller is the "target" proxy
let caller: T::AccountId = account("target", p - 1, SEED);
T::Currency::make_free_balance_be(&caller, BalanceOf::<T>::max_value() / 2u32.into());
// ... and "real" is the traditional caller. This is not a typo.
let real: T::AccountId = whitelisted_caller();
let real_lookup = T::Lookup::unlookup(real);
let call: <T as Config>::RuntimeCall = frame_system::Call::<T>::remark { remark: vec![] }.into();
}: _(RawOrigin::Signed(caller), real_lookup, Some(T::ProxyType::default()), Box::new(call))
verify {
assert_last_event::<T>(Event::ProxyExecuted { result: Ok(()) }.into())

#[extrinsic_call]
_(RawOrigin::Signed(caller), real_lookup, Some(T::ProxyType::default()), Box::new(call));

assert_last_event::<T>(Event::ProxyExecuted { result: Ok(()) }.into());

Ok(())
}


proxy_announced {
let a in 0 .. T::MaxPending::get() - 1;
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
#[benchmark]
fn proxy_announced(a: Linear<0, { T::MaxPending::get() - 1 }>, p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
// In this case the caller is the "target" proxy
let caller: T::AccountId = account("pure", 0, SEED);
let delegate: T::AccountId = account("target", p - 1, SEED);
Expand All @@ -112,14 +120,18 @@ benchmarks! {
T::CallHasher::hash_of(&call),
)?;
add_announcements::<T>(a, Some(delegate.clone()), None)?;
}: _(RawOrigin::Signed(caller), delegate_lookup, real_lookup, Some(T::ProxyType::default()), Box::new(call))
verify {
assert_last_event::<T>(Event::ProxyExecuted { result: Ok(()) }.into())
}

#[extrinsic_call]
_(RawOrigin::Signed(caller), delegate_lookup, real_lookup, Some(T::ProxyType::default()), Box::new(call));

assert_last_event::<T>(Event::ProxyExecuted { result: Ok(()) }.into());

remove_announcement {
let a in 0 .. T::MaxPending::get() - 1;
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
Ok(())
}

#[benchmark]
fn remove_announcement(a: Linear<0, { T::MaxPending::get() - 1 }>, p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
// In this case the caller is the "target" proxy
let caller: T::AccountId = account("target", p - 1, SEED);
T::Currency::make_free_balance_be(&caller, BalanceOf::<T>::max_value() / 2u32.into());
Expand All @@ -133,15 +145,19 @@ benchmarks! {
T::CallHasher::hash_of(&call),
)?;
add_announcements::<T>(a, Some(caller.clone()), None)?;
}: _(RawOrigin::Signed(caller.clone()), real_lookup, T::CallHasher::hash_of(&call))
verify {

#[extrinsic_call]
_(RawOrigin::Signed(caller.clone()), real_lookup, T::CallHasher::hash_of(&call));

let (announcements, _) = Announcements::<T>::get(&caller);
assert_eq!(announcements.len() as u32, a);

Ok(())
}

reject_announcement {
let a in 0 .. T::MaxPending::get() - 1;
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
#[benchmark]
fn reject_announcement(a: Linear<0, { T::MaxPending::get() - 1 }>, p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
// In this case the caller is the "target" proxy
let caller: T::AccountId = account("target", p - 1, SEED);
let caller_lookup = T::Lookup::unlookup(caller.clone());
Expand All @@ -156,15 +172,19 @@ benchmarks! {
T::CallHasher::hash_of(&call),
)?;
add_announcements::<T>(a, Some(caller.clone()), None)?;
}: _(RawOrigin::Signed(real), caller_lookup, T::CallHasher::hash_of(&call))
verify {

#[extrinsic_call]
_(RawOrigin::Signed(real), caller_lookup, T::CallHasher::hash_of(&call));

let (announcements, _) = Announcements::<T>::get(&caller);
assert_eq!(announcements.len() as u32, a);

Ok(())
}

announce {
let a in 0 .. T::MaxPending::get() - 1;
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
#[benchmark]
fn announce(a: Linear<0, { T::MaxPending::get() - 1 }>, p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
// In this case the caller is the "target" proxy
let caller: T::AccountId = account("target", p - 1, SEED);
T::Currency::make_free_balance_be(&caller, BalanceOf::<T>::max_value() / 2u32.into());
Expand All @@ -174,72 +194,90 @@ benchmarks! {
add_announcements::<T>(a, Some(caller.clone()), None)?;
let call: <T as Config>::RuntimeCall = frame_system::Call::<T>::remark { remark: vec![] }.into();
let call_hash = T::CallHasher::hash_of(&call);
}: _(RawOrigin::Signed(caller.clone()), real_lookup, call_hash)
verify {

#[extrinsic_call]
_(RawOrigin::Signed(caller.clone()), real_lookup, call_hash);

assert_last_event::<T>(Event::Announced { real, proxy: caller, call_hash }.into());

Ok(())
}

add_proxy {
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
fn add_proxy(p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
let caller: T::AccountId = whitelisted_caller();
let real = T::Lookup::unlookup(account("target", T::MaxProxies::get(), SEED));
}: _(
RawOrigin::Signed(caller.clone()),
real,
T::ProxyType::default(),
BlockNumberFor::<T>::zero()
)
verify {

#[extrinsic_call]
_(
RawOrigin::Signed(caller.clone()),
real,
T::ProxyType::default(),
BlockNumberFor::<T>::zero()
);

let (proxies, _) = Proxies::<T>::get(caller);
assert_eq!(proxies.len() as u32, p + 1);

Ok(())
}

remove_proxy {
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
fn remove_proxy(p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
let caller: T::AccountId = whitelisted_caller();
let delegate = T::Lookup::unlookup(account("target", 0, SEED));
}: _(
RawOrigin::Signed(caller.clone()),
delegate,
T::ProxyType::default(),
BlockNumberFor::<T>::zero()
)
verify {

#[extrinsic_call]
_(
RawOrigin::Signed(caller.clone()),
delegate,
T::ProxyType::default(),
BlockNumberFor::<T>::zero()
);

let (proxies, _) = Proxies::<T>::get(caller);
assert_eq!(proxies.len() as u32, p - 1);

Ok(())
}

remove_proxies {
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
fn remove_proxies(p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
let caller: T::AccountId = whitelisted_caller();
}: _(RawOrigin::Signed(caller.clone()))
verify {

#[extrinsic_call]
_(RawOrigin::Signed(caller.clone()));

let (proxies, _) = Proxies::<T>::get(caller);
assert_eq!(proxies.len() as u32, 0);

Ok(())
}

create_pure {
let p in 1 .. (T::MaxProxies::get() - 1) => add_proxies::<T>(p, None)?;
fn create_pure(p: Linear<1, { T::MaxProxies::get() - 1 }>) -> Result<(), BenchmarkError> {
add_proxies::<T>(p, None)?;
let caller: T::AccountId = whitelisted_caller();
}: _(
RawOrigin::Signed(caller.clone()),
T::ProxyType::default(),
BlockNumberFor::<T>::zero(),
0
)
verify {

#[extrinsic_call]
_(
RawOrigin::Signed(caller.clone()),
T::ProxyType::default(),
BlockNumberFor::<T>::zero(),
0
);

let pure_account = Pallet::<T>::pure_account(&caller, &T::ProxyType::default(), 0, None);
assert_last_event::<T>(Event::PureCreated {
pure: pure_account,
who: caller,
proxy_type: T::ProxyType::default(),
disambiguation_index: 0,
}.into());
}

kill_pure {
let p in 0 .. (T::MaxProxies::get() - 2);
Ok(())
}

fn kill_pure(p: Linear<1, { T::MaxProxies::get() - 2 }>) -> Result<(), BenchmarkError> {
let caller: T::AccountId = whitelisted_caller();
let caller_lookup = T::Lookup::unlookup(caller.clone());
T::Currency::make_free_balance_be(&caller, BalanceOf::<T>::max_value());
Expand All @@ -255,9 +293,13 @@ benchmarks! {

add_proxies::<T>(p, Some(pure_account.clone()))?;
ensure!(Proxies::<T>::contains_key(&pure_account), "pure proxy not created");
}: _(RawOrigin::Signed(pure_account.clone()), caller_lookup, T::ProxyType::default(), 0, height, ext_index)
verify {

#[extrinsic_call]
_(RawOrigin::Signed(pure_account.clone()), caller_lookup, T::ProxyType::default(), 0, height, ext_index)

Check failure on line 298 in substrate/frame/proxy/src/benchmarking.rs

View workflow job for this annotation

GitHub Actions / cargo-check-all-crate-macos 

expected `;`, found `assert`

assert!(!Proxies::<T>::contains_key(&pure_account));

Ok(())
}

impl_benchmark_test_suite!(Proxy, crate::tests::new_test_ext(), crate::tests::Test);
Expand Down

0 comments on commit bf177fc

Please sign in to comment.