Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignedExtension to check Metadata Root Hash #2016

Closed
2 tasks done
SBalaguer opened this issue Oct 24, 2023 · 7 comments
Closed
2 tasks done

Add SignedExtension to check Metadata Root Hash #2016

SBalaguer opened this issue Oct 24, 2023 · 7 comments
Labels
I5-enhancement An additional feature request.

Comments

@SBalaguer
Copy link
Contributor

SBalaguer commented Oct 24, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

Offline signer experience in the Polkadot ecosystem can be massively improved. Today there is either too much manual, no scalable work (Ledger) or simply too much trust deposit on a third party (Polkadot Vault / Kampela).
The Zondax and Alzymologist team provided a way to solve these issues to the Polkadot Community on Ref #62. This gave way to the 'Metadata for Offline Signers' project that can be tracked here.

Related: #291

Request

The proposed solution is to maximize the usage of the Metadata so as to provide the right information to the offline signer. As this needs to be passed to the signer by some third party software, in order to avoid attacks the proposal is to add a new SignedExtension that would add the check of the Metadata Root Hash. This will make it so that any transaction sent from an offline device will include the root hash and this information will be then checked by the runtime.

As to how calculate this metadata root hash, there's a spec description and a reference implementation

Solution

No response

Are you willing to help with this request?

Yes!

@SBalaguer SBalaguer added the I5-enhancement An additional feature request. label Oct 24, 2023
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Oct 24, 2023
@ggwpez ggwpez removed the I10-unconfirmed Issue might be valid, but it's not yet known. label Oct 24, 2023
@ggwpez
Copy link
Member

ggwpez commented Oct 24, 2023

Yea sounds good. Maybe could to for an RFC (but not sure if its a must here) https://github.com/polkadot-fellows/RFCs

@SBalaguer
Copy link
Contributor Author

Yep, not super sure myself either! If need be down the line, happy to do it :)

@bkchr
Copy link
Member

bkchr commented Oct 24, 2023

there's a spec

That is not really a spec ;)

@bkchr
Copy link
Member

bkchr commented Oct 24, 2023

Having a RFC for the spec would be a good start IMO.

@SBalaguer
Copy link
Contributor Author

@bkchr edit from spec to description to make it clearer. We'll move ahead then with the RFC first and then come back here.

@bkchr
Copy link
Member

bkchr commented Oct 25, 2023

Ty! The extension will actually not be that complicated, more integrating this into the build process. However, even the integration to the build process will be easy against the metadata merkleization.

serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
Signed-off-by: acatangiu <adrian@parity.io>
@bkchr
Copy link
Member

bkchr commented Apr 24, 2024

Duplicate of: #291

@bkchr bkchr closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request.
Projects
Status: Done
Development

No branches or pull requests

3 participants