Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_extrinsic in BlockWeight limit per class should take into account base_block #329

Open
gui1117 opened this issue Mar 23, 2021 · 2 comments
Open

max_extrinsic in BlockWeight limit per class should take into account base_block #329

gui1117 opened this issue Mar 23, 2021 · 2 comments
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@gui1117
Copy link
Contributor

gui1117 commented Mar 23, 2021

when computing what is the maximal weight for an extrinsic of a given class we have to manually substract the base_block weight.

https://github.com/paritytech/substrate/blob/fcf950ca4906bed0b8118d6b40fa8a8a0acf9425/bin/node/runtime/src/lib.rs#L512-L515

Instead max_extrinsic should take into account that the weight consume by base_block is not available:

https://github.com/paritytech/substrate/blob/fcf950ca4906bed0b8118d6b40fa8a8a0acf9425/frame/system/src/limits.rs#L406-L416
@gui1117 gui1117 mentioned this issue Mar 23, 2021
Merged
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@gui1117
Copy link
Contributor Author

gui1117 commented Jul 8, 2021

still sensible to me

@stale stale bot removed the A5-stale label Jul 8, 2021
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@Rizziepit
Limit number of messages in commitment queues (paritytech#329)
35991c7 
* Limit number of messages in commitment queues

* Set commitment queue limit to 20, try_mutate -> decode_len + append
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@boundless-forest
Correct load transactions by hash (paritytech#329)
ed80fba 
* Correct load transactions by hash

* Make rustc happy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@dependabot-preview
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
ffbedd5
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@dependabot-preview
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
f6a0f31
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
8b8bb77
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
d03e965
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
6ab00c8
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
92af4f0
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
0a6f5ed
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
7fb3fb9
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
7a5dd5f
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
9699f5a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
aa514a1
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
232d8d3
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
1380291
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @bkchr
Bump async-trait from 0.1.38 to 0.1.40 (paritytech#329)
112e604
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juangirini @gui1117 @the-right-joyce