Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize node test helpers #38

Closed
ggwpez opened this issue Aug 10, 2022 · 3 comments
Closed

Generalize node test helpers #38

ggwpez opened this issue Aug 10, 2022 · 3 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T10-tests This PR/Issue is related to tests.

Comments

@ggwpez
Copy link
Member

ggwpez commented Aug 10, 2022 •
edited by the-right-joyce
Loading

Stuff like wait_n_finalized_blocks is now part of Substrate, Polkadot and Cumulus, always in a slight variation.
Other candidates are wait_n_finalized_blocks_from, wait_n_finalized_blocks or find_ws_url_from_output, that seem useful in multiple projects.

We could probably generalize the implementations to be more maintainable instead of copy & pasting it.
@ggwpez ggwpez mentioned this issue Aug 10, 2022
Merged
@shawntabrizi
Copy link
Member

We should save this for onboarding some of our new employees

@the-right-joyce the-right-joyce transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T10-tests This PR/Issue is related to tests. I4-refactor Code needs refactoring. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed I5-tests labels Aug 25, 2023
@0xmovses
Copy link
Contributor

Picking this up.

@0xmovses
Copy link
Contributor

0xmovses commented Oct 14, 2023 •
edited
Loading

wait_n_finalized_blocks_from doesn't seem to exist in the monorepo. Seems like this refactor has already been done. find_ws_url_from_output, seems useful as a standalone function.

helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@tgmichel
Use runtime api version in NewPendingTransactions subscriptions (pa…
165c000 
…ritytech#597)

* Versioned runtime fixes 2 (paritytech#38)

(cherry picked from commit 7e4fd790f7592b77fab0b9007860d98335b2f133)
(cherry picked from commit a40e29a63f3923730e0e5807ddcc63aff5255d87)

* fmt
lexnv pushed a commit that referenced this issue Apr 3, 2024
@jsdw
Merge pull request #38 from tomaka/clarify-tx-submit
9312ef8 
Clarify that you can't cancel `transaction_unstable_submitAndWatch`
liuchengxu added a commit to subcoin-project/polkadot-sdk that referenced this issue Sep 20, 2024
@liuchengxu
Initial metrics integration (paritytech#37)
41535b4 
* refactoring: introduce Params in network worker

* Initial metrics in subcoin-network

* Initial metrics in sc-consensus-nakamoto

* Spawn prometheus service in import-blocks command

* Use GaugeVec for block_execution_time

* Rename --bootnode to --seednodes in subcoin networking params

* More subcoin network metrics

* Fix test

* FMT

* Add block transactions count metric

* Add docker

* Add dashboard.json

* Add README.md

* Update grafana README.md

* .

* Update dashboard.json

* Add block size metric

* Update readme (paritytech#38)

* Update README.md

* Update README.md

* Update README.md

* .

* .

* .

* Update README.md

* Update README.md

* Update README.md

* Rate limiting on metric report of block_execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T10-tests This PR/Issue is related to tests.
Projects
SDK Node
Status: done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shawntabrizi @ggwpez @0xmovses @the-right-joyce