Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit safe-mode and tx-pause #4445

Closed
ggwpez opened this issue May 13, 2024 · 3 comments
Closed

Audit safe-mode and tx-pause #4445

ggwpez opened this issue May 13, 2024 · 3 comments
Assignees
@ggwpez

Comments

@ggwpez
Copy link
Member

ggwpez commented May 13, 2024

Pallets introduced in paritytech/substrate#12092 do need audit.
@ggwpez
Copy link
Member Author

ggwpez commented May 27, 2024

already done

@ggwpez ggwpez closed this as completed May 27, 2024
@wischli
Copy link

wischli commented Jul 23, 2024

Hey @ggwpez. According to this issue, both pallets have been audited. However, the docs state they have not been audited. I suppose the docs are outdated?

Assuming both have been audited, can you point me to the audit report please? I'd also love to know the first SDK version in which they have been officially audited. Thank you in advance!

ggwpez added a commit that referenced this issue Jul 23, 2024
@ggwpez
Remove audit warning
3b564e5 
Pallet tx-pause and safe-mode are both audited, see: #4445

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this issue Jul 23, 2024
Merged
@ggwpez
Copy link
Member Author

ggwpez commented Jul 23, 2024

I am removing the warnings now #5114 and pinged the security team if they have some report, normally i would assume not, but we wanted to have some proper audit tracking for a while now.

github-merge-queue bot pushed a commit that referenced this issue Jul 23, 2024
@ggwpez
Remove not-audited warning (#5114)
604f56f 
Pallet tx-pause and safe-mode are both audited, see: #4445

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@ggwpez @TarekkMA
Remove not-audited warning (paritytech#5114)
db0f081 
Pallet tx-pause and safe-mode are both audited, see: paritytech#4445

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez self-assigned this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggwpez ggwpez

Labels
None yet
Projects
Security Audit (PRs) - SRLabs
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggwpez @wischli