Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCM: Transactional Processing #490

Closed
Tracked by #925
gavofyork opened this issue Oct 7, 2022 · 1 comment · Fixed by #1222 · May be fixed by paritytech/polkadot#6951
Closed
Tracked by #925

XCM: Transactional Processing #490

gavofyork opened this issue Oct 7, 2022 · 1 comment · Fixed by #1222 · May be fixed by paritytech/polkadot#6951
Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.

Comments

@gavofyork
Copy link
Member

For XCM instructions which are unable to avoid any state changes on an error, use a storage transaction to ensure that changes are rolled back in the case of an error after changes have been made. Instructions which need this are:

  • WithdrawAsset
  • ReserveAssetDeposited
  • TransferAsset
  • TransferReserveAsset
  • ReceiveTeleportedAsset
  • DepositAsset
  • DepositReserveAsset
  • InitiateReserveWithdraw
  • InitiateTeleport
  • BuyExecution
  • ClaimAsset
  • ExportMessage
  • LockAsset
  • UnlockAsset
  • RequestUnlock

Each should have their implementations in XcmExecutor::process_instruction be wrapped in a storage transaction which reverts any changes in case an Err value is returned.
@gavofyork gavofyork mentioned this issue Aug 24, 2023
Open
30 tasks
@gavofyork gavofyork changed the title XCM Transactional Processing XCM: Transactional Processing Oct 7, 2022
@KiChjang KiChjang added the T6-XCM This PR/Issue is related to XCM. label Mar 6, 2023
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/how-to-handle-not-withdrawable-assets-properly-with-xcm/2270/4

@vstam1 vstam1 mentioned this issue Mar 24, 2023
Open
@juangirini juangirini transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed J0-enhancement labels Aug 25, 2023
@vstam1 vstam1 mentioned this issue Aug 28, 2023
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2024
@vstam1 @KiChjang @franciscoaguirre
Transactional processing for XCM (#1222)
50eb12c 
Moved from: paritytech/polkadot#6951

closes #490

- [x] update cumulus

--- 
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.


Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
franciscoaguirre added a commit to paritytech/xcm that referenced this issue Jan 25, 2024
@vstam1 @KiChjang @franciscoaguirre
Transactional processing for XCM (#1222)
2870a4b 
Moved from: paritytech/polkadot#6951

closes paritytech/polkadot-sdk#490

- [x] update cumulus

--- 
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
paritytech/polkadot-sdk#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.


Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
ggwpez pushed a commit that referenced this issue Jan 29, 2024
@vstam1 @KiChjang
@franciscoaguirre @ggwpez
Transactional processing for XCM (#1222)
bdf2057 
Moved from: paritytech/polkadot#6951

closes #490

- [x] update cumulus

---
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.

Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
franciscoaguirre added a commit that referenced this issue Feb 1, 2024
@vstam1 @KiChjang @franciscoaguirre
Transactional processing for XCM (#1222)
e0bc77e 
Moved from: paritytech/polkadot#6951

closes #490

- [x] update cumulus

---
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.

Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
franciscoaguirre added a commit that referenced this issue Feb 5, 2024
@vstam1 @KiChjang @franciscoaguirre
Transactional processing for XCM (#1222)
5f8cb1c 
Moved from: paritytech/polkadot#6951

closes #490

- [x] update cumulus

---
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.

Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@vstam1 @KiChjang @franciscoaguirre
Transactional processing for XCM (paritytech#1222)
bd5326f 
Moved from: paritytech/polkadot#6951

closes paritytech#490

- [x] update cumulus

--- 
This PR introduces transactional processing of certain xcm instructions.
For the list of instructions checkout
paritytech#490. The transactional
processing is implemented as an xcm-executor config item. The two
implementations in this PR are `FrameTransactionalProcessor` and `()`.
The `()` implementation does no transactional processing. Each
implementation of the `ProcessTransaction` trait has an
`IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
is actually implemented. If Transactional processing is implemented,
changes to touched registers should also be rolled back to prevent
inconsistencies.


Note for reviewers:
Check out the following safety assumption:
https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
4 participants
@gavofyork @KiChjang @the-right-joyce @Polkadot-Forum