Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide of the reliability and ordering guarantees of notifications (and implement them) #552

Open
tomaka opened this issue Jul 29, 2020 · 0 comments
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 29, 2020

For context, see the discussion here: paritytech/substrate#6692 (comment)

It is unclear at the moment whether the notifications sent using NetworkService::write_notification or NetworkService::notification_sender provide some guarantee that the notifications will reach their destination and in the same order as they have been sent.

99.9% of the time the notifications will indeed reach their destination and in the correct order. The problematic situations are corner cases, most notably the situation where we have multiple connections open, and one of them closes.

cc @romanb

@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I4-annoyance labels Aug 25, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
Status: Backlog 🗒
Development

No branches or pull requests

3 participants