Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of disabled validators in backing subsystem #1259
Handling of disabled validators in backing subsystem #1259
Changes from 37 commits
800d8e5
936216d
7165ef9
24b5df5
eaca5ed
e4dee17
23023c4
8db76f5
e2846b2
8604b69
78afa76
9e39e58
0d0129c
23fbb41
91d1a8d
3d7efab
e68fa6a
5e7655f
c6bca9c
6fb4b7f
70dc6b6
bca3c83
f717d0b
2a5af89
2c53894
26866fa
a3bcb2f
863fc7d
c44093d
1e561e9
cf671f4
8807981
55f8e01
b5609e1
617e477
d7f4315
718f04b
275ce02
f2b17f1
7872f8f
3c89059
15b5069
96c1358
1a6648a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to return Option ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.validator
is anOption
. Afair the code can be executed in cases where the local node is not a validator?I decided to return an
Option
here too and handle it at the caller.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code needs to stay until we release v8: #1940
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we extract that into subsystem-util or somewhere where statement-distribution and dispute-coordinator can reuse it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking about the same and I started working on it but against master.
My idea is to have a wrapper around
request_from_runtime
which does a version check and optionally returns a fallback version. I'll open a PR against master because I think this will be useful in general. We can backport it here easily after that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went into a macro rabbit hole. I'll just extract this implementation here and finish the other version in a more appropriate time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds good. However, I didn't mean to use a macro for that, just a regular function should be OK.