Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code duplication in tests #1575

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Fix code duplication in tests #1575

merged 6 commits into from
Sep 14, 2023

Conversation

tdimitrov
Copy link
Contributor

The PR contains two changes:

  • Extract some duplicated code from backing tests as functions.
  • Move validator_pubkeys to test helpers

ordian
ordian approved these changes Sep 14, 2023
View reviewed changes
polkadot/node/core/backing/src/tests/mod.rs Outdated Show resolved Hide resolved
polkadot/node/core/backing/src/tests/mod.rs Outdated Show resolved Hide resolved
eskimor
eskimor reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Approving module Andronik's nits.

@tdimitrov tdimitrov merged commit d81a2e2 into master Sep 14, 2023
109 of 111 checks passed
@tdimitrov tdimitrov deleted the tsv-tests-refactoring branch September 14, 2023 19:49
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@svyatonik
use transaction tracker in parachains relay (paritytech#1575)
8559b89 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@svyatonik
use transaction tracker in parachains relay (paritytech#1575)
48cb59a 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik
use transaction tracker in parachains relay (paritytech#1575)
29989aa 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
ea4c515 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
4eefc21 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
7487bc0 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
bb6ee0d 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
da313a1 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
3527c1e 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
e31f95e 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
4f7c785 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
8729fea 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
85efbca 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
662837e 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
use transaction tracker in parachains relay (paritytech#1575)
1f58d33 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
use transaction tracker in parachains relay (#1575)
86be60a 
* use transaction tracker in parachains relay

* actually return tx tracker from target client implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskimor eskimor eskimor approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdimitrov @eskimor @ordian