Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking: Add dest to Rewarded to aid in reward calculations #1602

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Staking: Add dest to Rewarded to aid in reward calculations #1602

merged 6 commits into from
Sep 18, 2023

Conversation

rossbulat
Copy link

Addresses #129.

Returns Self:payee() from make_payout in a tuple alongside an imbalance & adds it to Rewarded event.

@rossbulat rossbulat requested review from a team September 17, 2023 10:27
@rossbulat rossbulat added I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet. labels Sep 17, 2023
kianenigma
kianenigma approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add some sort of "check events" to one test that covers this and make sure it won't regress.

@rossbulat rossbulat enabled auto-merge (squash) September 18, 2023 17:17
@rossbulat rossbulat merged commit ffe5db0 into master Sep 18, 2023
107 of 109 checks passed
@rossbulat rossbulat deleted the rb-payee-in-rewarded branch September 18, 2023 17:32
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Staking: Add dest to Rewarded to aid in reward calculations (pari…
a76b751 
…tytech#1602)

Addresses paritytech#129.

Returns `Self:payee()` from `make_payout` in a tuple alongside an
imbalance & adds it to `Rewarded` event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@lexnv lexnv lexnv approved these changes

@Ank4n Ank4n Awaiting requested review from Ank4n

@gpestana gpestana Awaiting requested review from gpestana

Assignees
No one assigned
Labels
I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossbulat @kianenigma @lexnv