Broker pallet: RegionDropped event fix & additional tests
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
Sep 18, 2023
|
Marking as silent since the pallet is not live yet. |
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…ch#1609) This PR includes the following fix: - [x] The `duration` is always set to zero in the `RegionDropped` event. This is fixed in this PR. Also added some additional tests to cover some cases that aren't covered : - [x] Selling a partitioned region to the instantaneous coretime pool. - [x] Partitioning a region after assigning it to a particular task. - [x] Interlacing a region after assigning it to a particular task.
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Move some logic to RestartableFinalityProofsStream * Move some logic to `Transaction` * Avoid unnecessary split_off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following fix:
durationis always set to zero in theRegionDroppedevent. This is fixed in this PR.Also added some additional tests to cover some cases that aren't covered :