Refactors referenda pallet to use fungible traits #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
gpestana
added
C1-mentor
|
The CI pipeline was cancelled due to failure one of the required jobs. |
juangirini
reviewed
Oct 23, 2023
ggwpez
approved these changes
Nov 23, 2023
| @@ -139,6 +140,7 @@ const ASSEMBLY_ID: LockIdentifier = *b"assembly"; | |||
|
|
|||
| #[frame_support::pallet] | |||
| pub mod pallet { | |||
|
|
|||
|
|
||
| Self::deposit_event(Event::<T, I>::DepositSlashed { | ||
| who, | ||
| amount: amount.saturating_sub(non_slashed), |
There was a problem hiding this comment.
I think its possible to first emit the event and use imbalance.peek(), that makes it a bit more understandable IMHO.
| { | ||
| fn on_nonzero_unbalanced(amount: Credit<<T as frame_system::Config>::AccountId, F>) { | ||
| let peeked_amount = amount.peek(); | ||
| let _ = F::resolve(&<Pallet<T, I>>::account_id(), amount); |
There was a problem hiding this comment.
If this fails then the credit is just dropped correctly, or?
liamaharon
reviewed
Nov 24, 2023
Comment on lines
+1119
to
1121
| /// Note: replace this implementation for [`FunOnUnbalanced`] once the `Currency` traits are | ||
| /// deprecated and not used anymore. | ||
| impl<T: Config<I>, I: 'static> OnUnbalanced<NegativeImbalanceOf<T, I>> for Pallet<T, I> { |
There was a problem hiding this comment.
Let's mark it deprecated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the referanda pallet to use the new fungible traits.
type pallet_treasury::FunOnUnbalanced: the treasury pallet implements a new type that handles fungible's imbalances to ensure forwards (traits::fungible) and backwards (traits::currency) compatibility. Once all pallets that use the treasury to handle imbalances move to fungibles, the currentimpl OnUnbalanced<NegativeImbalanceOf<T>> for Palletcan be removed.Todo:
HoldReasoncomposite enum in instatiable pallets #1839: There seems to be a problem with using theHoldReasonenum composite in the context of instantiable pallets.Related to #226