Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testnet] AssetHubRococo nits #1954

Merged
merged 4 commits into from
Oct 20, 2023
Merged

[testnet] AssetHubRococo nits #1954

merged 4 commits into from
Oct 20, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 20, 2023

This PR addresses several minor issues:

  • Fixes the symlink for asset-hub-rococo.json chainspec.
  • Corrects the asset-hub-rococo-genesis invulnerables setup.
  • Relocates common bash functions for bridge testing to a separate file bridges_common.sh.

@bkontur bkontur added the T9-cumulus This PR/Issue is related to cumulus. label Oct 20, 2023
@bkontur bkontur enabled auto-merge (squash) October 20, 2023 12:01
@bkontur bkontur disabled auto-merge October 20, 2023 12:37
@bkontur bkontur enabled auto-merge (squash) October 20, 2023 12:48
@bkontur
Copy link
Contributor Author

bkontur commented Oct 20, 2023

@michalkucharczyk this PR fixes your comment

@bkontur @michalkucharczyk
Update cumulus/polkadot-parachain/src/chain_spec/asset_hubs.rs
eaea916 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@michalkucharczyk
Copy link
Contributor

chain spec part looks good.

@bkontur bkontur mentioned this pull request Oct 20, 2023
Merged
8 tasks
@bkontur bkontur merged commit 7699435 into master Oct 20, 2023
104 of 117 checks passed
@bkontur bkontur deleted the bko-asset-hub-rococo-nits branch October 20, 2023 13:47
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svyatonik svyatonik svyatonik approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkontur @michalkucharczyk @svyatonik @acatangiu