Pallet Elections Phragment migrates to use Fungibles trait #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirednkod
added
T1-FRAME
33 tasks
gpestana
reviewed
Jun 14, 2024
| #[pallet::config] | ||
| pub trait Config: frame_system::Config { | ||
| pub trait Config: frame_system::Config | ||
| where |
There was a problem hiding this comment.
Double check whether we need this constraints.
| @@ -196,17 +206,59 @@ pub mod pallet { | |||
| #[pallet::without_storage_info] | |||
| pub struct Pallet<T>(_); | |||
|
|
|||
| #[pallet::composite_enum] | |||
| pub enum HoldReason<I: 'static = ()> { | |||
There was a problem hiding this comment.
Suggested change
| pub enum HoldReason<I: 'static = ()> { | |
| pub enum HoldReason<I: 'static = ()> { | |
| /// Hold deposit for phragmen pallet. | |
| Phragmen, | |
| } |
|
|
||
| /// A reason for freezing funds. | ||
| #[pallet::composite_enum] | ||
| pub enum FreezeReason<I: 'static = ()> { |
There was a problem hiding this comment.
similar as as HoldReason.
| let _remainder = T::Currency::unreserve(&who, to_unreserve); | ||
| debug_assert!(_remainder.is_zero()); | ||
| // Must unreserve a bit. | ||
| let released = T::Currency::release_all( |
There was a problem hiding this comment.
This should be release(to_unreserve) and not release_all
| }, | ||
| }; | ||
|
|
||
| // Amount to be locked up. | ||
| let locked_stake = value.min(T::Currency::free_balance(&who)); | ||
| T::Currency::set_lock(T::PalletId::get(), &who, locked_stake, WithdrawReasons::all()); | ||
| let locked_stake = value.min(T::Currency::balance(&who)); |
There was a problem hiding this comment.
Suggested change
| let locked_stake = value.min(T::Currency::balance(&who)); | |
| let locked_stake = value.min(T::Currency::reducible_balance(&who, ....)); |
Probably?
There was a problem hiding this comment.
Also, why do we need to lock and reserve in the same action?
| debug_assert!(_remainder.is_zero()); | ||
|
|
||
| let released = T::Currency::release_all( | ||
| &HoldReason::ReleaseForRunnerUp.into(), |
There was a problem hiding this comment.
Suggested change
| &HoldReason::ReleaseForRunnerUp.into(), | |
| &HoldReason::Candidacy.into() |
| @@ -529,8 +596,12 @@ pub mod pallet { | |||
| .binary_search_by(|(c, _)| c.cmp(&who)) | |||
| .map_err(|_| Error::<T>::InvalidRenouncing)?; | |||
| let (_removed, deposit) = candidates.remove(index); | |||
| let _remainder = T::Currency::unreserve(&who, deposit); | |||
| debug_assert!(_remainder.is_zero()); | |||
| let _released = T::Currency::release( | |||
There was a problem hiding this comment.
We should not release here again, maybe thaw?
| @@ -737,7 +808,7 @@ pub mod pallet { | |||
| .map(|(ref member, ref stake)| { | |||
| // make sure they have enough stake. | |||
| assert!( | |||
| T::Currency::free_balance(member) >= *stake, | |||
| T::Currency::balance(member) >= *stake, | |||
|
The CI pipeline was cancelled due to failure one of the required jobs. |
…polkadot-sdk into elections-phragment-fungibles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Elections Phragment pallet to use the fungible traits instead of the Currency trait (More information appear on #226);